Issue 33228 - rsc2 breaks in module sc
Summary: rsc2 breaks in module sc
Status: CLOSED WONT_FIX
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 1.1.2
Hardware: All Windows XP
: P3 Trivial (vote)
Target Milestone: OOo 1.1.4
Assignee: gregor.hartmann
QA Contact: issues@tools
URL:
Keywords:
: 41237 (view as issue list)
Depends on:
Blocks:
 
Reported: 2004-08-19 18:18 UTC by ivo.hinkelmann
Modified: 2005-01-24 22:18 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
avoid overflow in rsc (2.95 KB, patch)
2004-09-10 13:56 UTC, philipp.lohmann 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description ivo.hinkelmann 2004-08-19 18:18:20 UTC 
rsc2 breaks in module sc with the activated languages RES_THAI and/or
RES_KANNADA. It looks like there is somewhere a buffer overflow. Possible one of
the strings or string list is too long.
Comment 1 pavel 2004-08-20 20:49:54 UTC 
I have seend this with KANNADA. But only on Windows. GNU/Linux builds work
correctly without problem. I'll report status on Solaris/SPARC soon.
Comment 2 pavel 2004-08-22 08:25:36 UTC 
My build on Solaris/SPARC wentfine even with KANNADA defined.

So this seems to be Windows only.

Volker added himself to CC: ;-)
Comment 3 ivo.hinkelmann 2004-08-23 13:19:43 UTC 
-> reassigned to pl
Comment 4 philipp.lohmann 2004-09-06 14:33:57 UTC 
sc/source/ui/src does not contain any KANNADA or THAI; neither in 645 nor in
680. Wo where can one reproduce this issue ?
Comment 5 pavel 2004-09-07 18:44:26 UTC 
pl: SRX645_m46:

pavel@pavel:~/.ooo/ooo_SRX645_m46_src> grep -r kannada sw|wc -l
3195
Comment 6 pavel 2004-09-08 13:09:07 UTC 
pl: you're right that directory doesn't contain any kannada resource. Ivo
probably removed them because of problems because original GSI for Kannada
contains sctings in that directory.
Comment 7 philipp.lohmann 2004-09-08 14:49:53 UTC 
no method of reproduction - no fix
Comment 8 philipp.lohmann 2004-09-08 15:46:53 UTC 
even funnier: i got the kannada and thai strings in sc out of CWS ooo113l10nfix,
and could build the corresponding resources on m46 flawlessly.

stranger and stranger.
Comment 9 philipp.lohmann 2004-09-09 11:57:01 UTC 
fixed in CWS ooo113l10nfix

gh: please verify
Comment 10 philipp.lohmann 2004-09-09 11:58:19 UTC 
fixed
Comment 11 gregor.hartmann 2004-09-09 16:29:21 UTC 
Seems to work
Comment 12 gregor.hartmann 2004-09-10 09:08:43 UTC 
compiling the ressources works but insertfunction in calc freezes the office
(sometimes got GPF also)
Fount in cannada

OK  in german,thai and arabic  (arbitrary selected list)
Comment 13 gregor.hartmann 2004-09-10 09:11:10 UTC 
.
Comment 14 philipp.lohmann 2004-09-10 12:35:47 UTC 
Will fix that problem in 2.0 by changing the resource file format to 32 bit
offsets. This is obviously unthinkable for 1.1, so i'll say too long languages
need to be shortened.
Comment 15 philipp.lohmann 2004-09-10 12:36:03 UTC 
fixed
Comment 16 philipp.lohmann 2004-09-10 13:56:06 UTC 
Created attachment 17651 [details]
avoid overflow in rsc
Comment 17 philipp.lohmann 2004-09-10 13:58:32 UTC 
will be built back, since even if rsc2 does not crash it will produce an invalid
resource file. This cannot be changed without changing the resource file format,
so users should have a notion that "something" broke.

Attached a diff for people that want to built all languages knowing that the
calc resource in some languages will be broken.
Comment 18 philipp.lohmann 2004-09-10 14:00:00 UTC 
wont fix in 1.1 tree, see issue 34002 for 2.0 tree. Furthermore the resource
format will be changed for 2.0 to accomodate 32bit offsets.
Comment 19 philipp.lohmann 2004-09-10 14:00:14 UTC 
closing
Comment 20 gregor.hartmann 2004-09-10 16:34:06 UTC 
OK finally we decided that it would be better to leave the patch in and print an
errormessage and break the build when the ressource exceeds 64K.
Comment 21 flibby05 2005-01-24 22:18:04 UTC 
*** Issue 41237 has been marked as a duplicate of this issue. ***